Re: [PATCH net v4?] net/mlx5: handle errors in mlx5_chains_create_table()

From: Markus Elfring
Date: Fri Mar 07 2025 - 08:46:49 EST


I suggest to reconsider the patch version number selection once more.


> In mlx5_chains_create_table(), the return value of mlx5_get_fdb_sub_ns()
> and mlx5_get_flow_namespace() must be checked to prevent NULL pointer
> dereferences. If either function fails, the function should log error
> message with mlx5_core_warn() and return error pointer.

Please improve such a change description another bit.

See also:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14-rc5#n94

Regards,
Markus