Re: [PATCH v3] scripts: generate_rust_analyzer.py: add missing macros deps

[Tamir Duberstein]

On Fri, Mar 7, 2025 at 6:48 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Fri, Mar 7, 2025 at 12:06 PM Tamir Duberstein <tamird@xxxxxxxxx> wrote:
> >
> > It's in anticipation of this follow up patch
> >
> > https://lore.kernel.org/all/20250209-rust-analyzer-host-v1-2-a2286a2a2fa3@xxxxxxxxx/
> >
> > where the return value is used to identify the crate. I developed the
> > two in parallel so I added this return to reduce overall churn.
>
> For this case, it is not a big deal (and sometimes it is a good idea,
> e.g. a `return` in a public API that wouldn't make sense not to have),
> but in general, please avoid doing things to avoid churn across series
> if that can confuse others -- future patches may or may not end up
> getting merged, so it is best not to rely on the future.

Makes sense, thanks.