Re: [PATCH 14/14] dt-bindings: mediatek: mt8196: add mt8196-mt6681 document

[Krzysztof Kozlowski]

On 07/03/2025 13:47, Darren.Ye wrote:
> From: Darren Ye <darren.ye@xxxxxxxxxxxx>
> 
> Add document for mt8196 board with mt6681.


Why do you add bindings after its users? Fix the order (see DT
submitting patches).


Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

> 
> Signed-off-by: Darren Ye <darren.ye@xxxxxxxxxxxx>
> ---
>  .../sound/mediatek,mt8196-mt6681.yaml         | 122 ++++++++++++++++++
>  1 file changed, 122 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml
> new file mode 100644
> index 000000000000..b144ba748c23
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8196-mt6681.yaml
> @@ -0,0 +1,122 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/mediatek,mt8196-mt6681.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT8196 ASoC sound card
> +
> +maintainers:
> +  - Darren Ye <darren.ye@xxxxxxxxxxxx>
> +
> +allOf:
> +  - $ref: sound-card-common.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - mediatek,mt8196-mt6681-sound
> +          - mediatek,mt8196-nau8825-sound
> +          - mediatek,mt8196-rt5682s-sound
> +          - mediatek,mt8196-rt5650-sound

So this is not compatible with nau8825?

> +      - items:
> +          - const: mediatek,mt8196-mt6681-sound

This makes no sense. Either it is or it is not compatible with nau8825.

> +          - const: mediatek,mt8196-nau8825-sound
> +
> +  audio-routing:
> +    description:
> +      Valid names could be the input or output widgets of audio components,
> +      power supplies, MicBias of codec and the software switch.

Drop property, not needed.

> +
Best regards,
Krzysztof