Re: [PATCH v5 4/4] rust: adding OwnableRefCounted and SimpleOwnableRefCounted

From: Alice Ryhl
Date: Fri Mar 07 2025 - 11:01:08 EST


On Fri, Mar 07, 2025 at 02:53:30PM +0100, Miguel Ojeda wrote:
> On Fri, Mar 7, 2025 at 2:28 PM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
> >
> > It's only a warning on older compilers. We could just add this in
> > lib.rs:
> >
> > #![allow(unknown_or_malformed_diagnostic_attributes)]
>
> That is OK too, though we would lose the check for typos until we
> upgrade the minimum.
>
> Hmm... Since we have nowadays the way to create those conditions
> easily, I think it is fine to do it conditionally.

Another possibility is to make the allow conditional.

Alice