Re: [PATCH] fs: support filename refcount without atomics

From: Jens Axboe
Date: Fri Mar 07 2025 - 11:18:52 EST


> +static inline void makeatomicname(struct filename *name)
> +{
> + VFS_BUG_ON(IS_ERR_OR_NULL(name));
> + /*
> + * The name can legitimately already be atomic if it was cached by audit.
> + * If switching the refcount to atomic, we need not to know we are the
> + * only non-atomic user.
> + */
> + VFS_BUG_ON(name->owner != current && !name->is_atomic);
> + /*
> + * Don't bother branching, this is a store to an already dirtied cacheline.
> + */
> + name->is_atomic = true;
> +}

Should this not depend on audit being enabled? io_uring without audit is
fine.

--
Jens Axboe