Re: [PATCH] tpm: Drop warning when an auth session is active
From: Jarkko Sakkinen
Date: Fri Mar 07 2025 - 11:39:57 EST
On Fri, Mar 07, 2025 at 10:56:44AM +0000, Jonathan McDowell wrote:
> Auth sessions are lazily flushed since commit df745e25098dc ("tpm:
> Lazily flush the auth session"), so it's expected that we might try to
> start a new session when one is still active.
>
> Signed-off-by: Jonathan McDowell <noodles@xxxxxxxx>
> ---
> drivers/char/tpm/tpm2-sessions.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
> index b70165b588ec..2d2c192ebb14 100644
> --- a/drivers/char/tpm/tpm2-sessions.c
> +++ b/drivers/char/tpm/tpm2-sessions.c
> @@ -982,7 +982,6 @@ int tpm2_start_auth_session(struct tpm_chip *chip)
> int rc;
>
> if (chip->auth) {
> - dev_warn_once(&chip->dev, "auth session is active\n");
> return 0;
> }
OK so curly faces should be also removed but I can adjust this
(if you don't mind), so we save all of us from trouble of
going through additional review round?
>
> --
> 2.48.1
>
BR, Jarkko