Re: [PATCH] rust: enable `clippy::ptr_as_ptr` lint

[Tamir Duberstein]

On Fri, Mar 7, 2025 at 12:04 PM Benno Lossin <benno.lossin@xxxxxxxxx> wrote:
>
> On Fri Mar 7, 2025 at 5:58 PM CET, Benno Lossin wrote:
> > On Fri Mar 7, 2025 at 5:41 PM CET, Tamir Duberstein wrote:
> >> In Rust 1.51.0, Clippy introduced the `ignored_unit_patterns` lint [1]:
> >
> > You link to the `ptr_as_ptr` lint though, is this a typo?
> >
> >>> Though `as` casts between raw pointers are not terrible,
> >>> `pointer::cast` is safer because it cannot accidentally change the
> >>> pointer's mutability, nor cast the pointer to other types like `usize`.
> >>
> >> There are a few classes of changes required:
> >> - Modules generated by bindgen are marked
> >>   `#[allow(clippy::ptr_as_ptr)]`.
> >> - Inferred casts (` as _`) are replaced with `.cast()`.
> >> - Ascribed casts (` as *... T`) are replaced with `.cast::<T>()`.
> >> - Multistep casts from references (` as *const _ as *const T`) are
> >>   replaced with `let x: *const _ = &x;` and `.cast()` or `.cast::<T>()`
> >>   according to the previous rules. The intermediate `let` binding is
> >>   required because `(x as *const _).cast::<T>()` results in inference
> >>   failure.
> >> - Native literal C strings are replaced with `c_str!().as_char_ptr()`.
> >
> > These all seem very nice, thanks! I think it would also be a good idea
> > to enable `ptr_cast_constness` [1], since those are the other kind of
> > `as` usage that we should be doing via `cast_mut`/`cast_const`.
>
> I didn't mean to make this sound like you *have* to do the work. If you
> find the time and want to do it, then great, otherwise we can turn this
> into a good-first-issue :)

No worries, I will give it a go.