Re: [PATCH v9 5/6] scanf: tidy header `#include`s

[Tamir Duberstein]

On Fri, Mar 7, 2025 at 12:40 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Fri, Mar 07, 2025 at 07:34:29PM +0200, Andy Shevchenko wrote:
> > On Fri, Mar 07, 2025 at 06:27:38AM -0500, Tamir Duberstein wrote:
>
> ...
>
> > >  #include <kunit/test.h>
> >
> > + array_size.h
> >
> > >  #include <linux/bitops.h>
>
> > + bug.h // BUILD_BUG_ON()
>
> Actually if it's only BUILD_BUG_ON(), then we better use build_bug.h.
>
> > + errno.h // actually asm/errno.h, but in C code the linux/* will suffice
> >
> > > -#include <linux/kernel.h>
> >
> > This was used like a "proxy" header to a lot, see around.
> >
> > >  #include <linux/module.h>
> > >  #include <linux/overflow.h>
> > >  #include <linux/prandom.h>
> > >  #include <linux/slab.h>
> > > -#include <linux/string.h>
> > > +#include <linux/sprintf.h>
> >
> > + types.h // u32, __scanf, ...
>
> ...
>
> > Note,the above I made based on the context of your changes, I haven't checked
> > the resulting file in full, please do it yourself.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

If it's easier to take this series without this patch, please do so --
my tools aren't giving me any help with IWYU and I'm not familiar
enough with the kernel to do a thorough manual job. As this is not
core to the goals of this series, I'd prefer not to hold it up over
it.

Thanks.

Tamir