Re: [PATCH] net: fix uninitialised access in mii_nway_restart()

From: Andrew Lunn
Date: Fri Mar 07 2025 - 12:56:39 EST


> Hi Andrew,
>
> Just following up on my patch regarding the uninitialized access fix in mii_nway_restart().
> As I mentioned in my previous message, how about an approach similar to the patch for ch9200_mdio_read()
> for get_mac_address() where we immediately check the return value of each control_read() call and return
> an error if any call fails? This way we don't continue if failure occurs. If you're good with this approach,
> should I submit a patch v2?

Yes, this would be good.

Thanks
Andrew