Re: [PATCH v1 1/7] auxdisplay: charlcd: Partially revert "Move hwidth and bwidth to struct hd44780_common"

[Andy Shevchenko]

On Fri, Mar 07, 2025 at 07:14:02PM +0100, Geert Uytterhoeven wrote:
> On Fri, 7 Mar 2025 at 17:57, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Fri, Mar 07, 2025 at 10:03:31AM +0100, Geert Uytterhoeven wrote:
> > > On Mon, 24 Feb 2025 at 18:30, Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > > The commit 2545c1c948a6 ("auxdisplay: Move hwidth and bwidth to struct
> > >
> > > s/The commit/Commit/
> >
> > Why? We know that we are talking about the very specific commit.
> 
> You can have a noun with or without an article:

This is not so simple :-), esp. if a noun is a weekday or a toponym.

>   - "a commit": an unspecified commit,
>   - "the commit": a specific commit, specified by context.
>   - "commit 1234abcd": a specific commit, specified by what follows.
> 
> > My English is not native I would appreciate a link to a material to study
> > the case you pointed out.
> 
> Neither is mine, but the use of articles is similar in English and Dutch.
> (I am aware your mother tongue does not have articles ;-)
> 
> I found plenty of articles explaining cases 1 and 2.
> Case 3 can be considered equivalent to "Mount Everest" in
> https://learnenglish.britishcouncil.org/grammar/a1-a2-grammar/articles-the-or-no-article

Okay, so you actually think that the hash and the title can be considered as
"name of a place". Hmm... I don't think it applies here. It's not a place.
Moreover some places require "the" article.

Here https://www.butte.edu/departments/cas/tipsheets/grammar/articles.html,
for example, the sentence "The 2003 federal budget" sounds to me closer to
our case. Every year there is a federal budget, but we explicitly point out
to one and reader knows what is this. The same with the commit.

Sorry, but I am still not convinced.

-- 
With Best Regards,
Andy Shevchenko