Re: [PATCH v2 2/3] spmi: add a spmi driver for Apple SoC

From: Alyssa Rosenzweig
Date: Fri Mar 07 2025 - 16:59:47 EST


> +static inline u32 read_reg(struct apple_spmi *spmi, int offset)
> +{
> + return readl(spmi->regs + offset);
> +}
> +
> +static inline void write_reg(u32 value, struct apple_spmi *spmi, int offset)
> +{
> + writel(value, spmi->regs + offset);
> +}

At this point I don't think these are gaining us anything. Can we inline
them?