Re: [PATCH V2] fs: binfmt_elf_efpic: fix variable set but not used warning
From: Kees Cook
Date: Fri Mar 07 2025 - 23:07:15 EST
On Sat, Mar 08, 2025 at 04:01:50AM +0000, Pedro Falcato wrote:
> On Sat, Mar 8, 2025 at 3:45 AM Kees Cook <kees@xxxxxxxxxx> wrote:
> >
> > On Sat, 08 Mar 2025 10:27:54 +0800, sunliming@xxxxxxxxx wrote:
> > > Fix below kernel warning:
> > > fs/binfmt_elf_fdpic.c:1024:52: warning: variable 'excess1' set but not
> > > used [-Wunused-but-set-variable]
> > >
> > >
> >
> > Adjusted Subject for typos.
> >
> > Applied to for-next/execve, thanks!
> >
> > [1/1] binfmt_elf_fdpic: fix variable set but not used warning
> > https://git.kernel.org/kees/c/7845fe65b33d
> >
>
> FYI, there's a typo so this patch won't compile
>
> >+ unsiged long excess1
> >+ = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK);
>
> s/unsiged/unsigned/
D'oh. Fixing in my tree..
--
Kees Cook