Re: [PATCH v6 4/7] drm/i915: Convert REG_GENMASK*() to fixed-width GENMASK_U*()

[Vincent Mailhol]

On 08/03/2025 at 02:54, Andy Shevchenko wrote:
> On Sat, Mar 08, 2025 at 01:48:51AM +0900, Vincent Mailhol via B4 Relay wrote:
>> From: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
>>
>> Now that include/linux/bits.h implements fixed-width GENMASK_U*(), use
>> them to implement the i915/xe specific macros. Converting each driver
>> to use the generic macros are left for later, when/if other
>> driver-specific macros are also generalized.
> 
> ...
> 
>> +/*
>> + * Wrappers over the generic BIT_* and GENMASK_* implementations,
> 
> BIT_U*(), GENMASK_U*() as far as I can see.
> 
> Also "...generic fixed-width...".

Ack. I will address both in next version.


Yours sincerely,
Vincent Mailhol