Re: [PATCH net-next v2 2/7] net: usb: lan78xx: Move fixed PHY cleanup to lan78xx_unbind()

[Maxime Chevallier]

Hi Oleksij,

On Fri,  7 Mar 2025 19:24:27 +0100
Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:

> Move the cleanup of the fixed PHY to the lan78xx_unbind() function,
> which is invoked during both the probe and disconnect paths.  This
> change eliminates duplicate cleanup code in the disconnect routine and
> ensures that the fixed PHY is properly freed during other probe steps.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---

The commit message looks totally unrelated to the content of the patch
:(

Maxime

>  drivers/net/usb/lan78xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index 01967138bc8c..4efe7a956667 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -2688,8 +2688,8 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
>  
>  	ret = phylink_connect_phy(dev->phylink, phydev);
>  	if (ret) {
> -		netdev_err(dev->net, "can't attach PHY to %s\n",
> -			   dev->mdiobus->id);
> +		netdev_err(dev->net, "can't attach PHY to %s, error %pe\n",
> +			   dev->mdiobus->id, ERR_PTR(ret));
>  		return -EIO;
>  	}
>