Re: [PATCH v2 1/2] x86/build: Remove -ffreestanding on i386 with GCC
From: Kees Cook
Date: Sat Mar 08 2025 - 12:23:32 EST
On Sat, Mar 08, 2025 at 10:17:46AM +0100, Nathan Chancellor wrote:
> On Fri, Mar 07, 2025 at 08:29:25PM -0800, Kees Cook wrote:
> > The use of -ffreestanding is a leftover that is only needed for certain
> > versions of Clang. Adjust this to be Clang-only. A later patch will make
> > this a versioned check.
> >
> > Signed-off-by: Kees Cook <kees@xxxxxxxxxx>
>
> This could also adjust the comment but it is probably not that big of a
> deal since the "temporary" is already pretty stale.
Ah yeah, good call. I'll fix that up locally.
>
> Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>
Thanks!
-Kees
--
Kees Cook