Re: [PATCH RFC] leds: rgb: leds-qcom-lpg: Compute PWM value based on period instead

[Uwe Kleine-König]

Hello Krzysztof,

On Fri, Mar 07, 2025 at 08:07:42AM +0100, Krzysztof Kozlowski wrote:
> On 07/03/2025 00:33, Uwe Kleine-König wrote:
> > So summarizing we have: Iff you use --base with a non-public commit, it's
> 
> Which is easily visible that it was not the case here. No human used
> format-patch thus no human used --base.

The human used b4 which used git format-patch --base (or something
equivalent). It really doesn't matter that it was only used indirectly,
my statement is true nevertheless.

> > useless and irrelevant. I fully agree. Our conclusion is different
> > though. You accept it's useless (and even request from me that I do the
> > same), and I asked the submitter to use --base as intended to make the
> > resulting information usable.
> 
> Because you expect additional steps for users of b4 and pointing in
> review standard use of b4 is extremely nitpicking.

My request makes the difference between having build bot coverage and
not having it. I consider that something important so I don't agree this
to be nitpicking.

Looking at
https://lore.kernel.org/all/?q=prerequisite-patch-id+change-id it also
doesn't seem soo unusual that people using b4 go through these
additional steps.

But I can hold out if you don't consider the result of patch checkers
relevant. That's why I intend to stop participating in this discussion
now.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature