Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements

From: Yunsheng Lin
Date: Sun Mar 09 2025 - 09:41:29 EST


On 3/8/2025 2:43 PM, Dave Chinner wrote:

...

I tested XFS using the below cmd and testcase, testing seems
to be working fine, or am I missing something obvious here
as I am not realy familiar with fs subsystem yet:

That's hardly what I'd call a test. It barely touches the filesystem
at all, and it is not exercising memory allocation failure paths at
all.

Go look up fstests and use that to test the filesystem changes you
are making. You can use that to test btrfs and NFS, too.

Thanks for the suggestion.
I used the below xfstests to do the testing in a VM, the smoke testing
seems fine for now, will do a full testing too:
https://github.com/tytso/xfstests-bld

Also, it seems the fstests doesn't support erofs yet?


-Dave.