Re: [PATCH V9 1/2] rust: module: change author to an array

[Miguel Ojeda]

On Sun, Mar 9, 2025 at 6:57 PM Guilherme Giacomo Simoes
<trintaeoitogc@xxxxxxxxx> wrote:
>
> -    if let Some(author) = info.author {
> -        modinfo.emit("author", &author);
> +    if let Some(authors) = info.authors {
> +        for author in authors {
> +            modinfo.emit("authors", &author);
> +        }

I guess nobody actually tested this... :)

The `modinfo` key should not change -- we want to still use `author`,
not `authors`, i.e. before this change:

    $ modinfo -k . -a samples/rust/rust_print.ko
    Rust for Linux Contributors

But after:

    $ modinfo -k . -a samples/rust/rust_print.ko

Anyway, I am considering applying this one with that fixed on my side,
but also, to simplify conflict handling, it may be best to keep the
old `author` field anyway working for a cycle or two (undocumented).

Guilherme: if I end up applying this, you can still send the second
patch on its own, based on top of `rust-next`, i.e. just the
`checkpatch.pl` one.

Cheers,
Miguel