Re: [PATCH net-next v4 2/2] net: hsr: Add KUnit test for PRP

[Jaakko Karrenpalo]

On Fri, Mar 7, 2025 at 3:04 PM Not Teknology <jkarrenpalo@xxxxxxxxx> wrote:
>
>
>
> On Fri, Mar 7, 2025, 03:52 Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>>
>> On Tue,  4 Mar 2025 12:40:30 +0200 Jaakko Karrenpalo wrote:
>> > Add unit tests for the PRP duplicate detection
>>
>> The patch appears unable to survive an allmodconfig build:
>> ERROR: modpost: "prp_register_frame_out" [net/hsr/prp_dup_discard_test.ko] undefined!
>>
>> Guessing that it ends up built in and the function is in a module?
>> Maybe a depends on ?
>> --
>> pw-bot: cr
>
>
> I used the wrong CONFIG_ define with IS_MODULE(). It should be the one without _MODULE at the end. Not that familiar with those.
>
> I must have messed up something when running the build locally, because I did manage to compile somehow.
>
> /Jaakko

And sorry about the previous mail not being plain text, gmail decided
to send it in html-mode

/Jaakko