Re: [PATCH] selftests/bpf: Convert comma to semicolon

[Anton Protopopov]

On 25/03/10 11:20AM, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.

This is a typo, of course. Thanks!

> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>

Acked-by: Anton Protopopov <aspsk@xxxxxxxxxxxxx>

> ---
>  tools/testing/selftests/bpf/prog_tests/fd_array.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/fd_array.c b/tools/testing/selftests/bpf/prog_tests/fd_array.c
> index a1d52e73fb16..9add890c2d37 100644
> --- a/tools/testing/selftests/bpf/prog_tests/fd_array.c
> +++ b/tools/testing/selftests/bpf/prog_tests/fd_array.c
> @@ -83,8 +83,8 @@ static inline int bpf_prog_get_map_ids(int prog_fd, __u32 *nr_map_ids, __u32 *ma
>  	int err;
>  
>  	memset(&info, 0, len);
> -	info.nr_map_ids = *nr_map_ids,
> -	info.map_ids = ptr_to_u64(map_ids),
> +	info.nr_map_ids = *nr_map_ids;
> +	info.map_ids = ptr_to_u64(map_ids);
>  
>  	err = bpf_prog_get_info_by_fd(prog_fd, &info, &len);
>  	if (!ASSERT_OK(err, "bpf_prog_get_info_by_fd"))
> -- 
> 2.25.1
>