Re: [PATCH] drm/gma500/psb_intel_modes: Remove unused psb_intel_ddc_probe

[Patrik Jakobsson]

On Sun, Mar 9, 2025 at 12:44 AM <linux@xxxxxxxxxxx> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> psb_intel_ddc_probe() was added in 2011 by
> commit 89c78134cc54 ("gma500: Add Poulsbo support")
> but has remained unused (probably because drm_get_edid is used
> instead).
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Applied to drm-misc-next
Thanks

> ---
>  drivers/gpu/drm/gma500/psb_intel_drv.h   |  1 -
>  drivers/gpu/drm/gma500/psb_intel_modes.c | 31 ------------------------
>  2 files changed, 32 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500/psb_intel_drv.h
> index 2499fd6a80c9..d80f2d0b712e 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_drv.h
> +++ b/drivers/gpu/drm/gma500/psb_intel_drv.h
> @@ -182,7 +182,6 @@ struct gma_i2c_chan *gma_i2c_create(struct drm_device *dev, const u32 reg,
>  void gma_i2c_destroy(struct gma_i2c_chan *chan);
>  int psb_intel_ddc_get_modes(struct drm_connector *connector,
>                             struct i2c_adapter *adapter);
> -extern bool psb_intel_ddc_probe(struct i2c_adapter *adapter);
>
>  extern void psb_intel_crtc_init(struct drm_device *dev, int pipe,
>                             struct psb_intel_mode_device *mode_dev);
> diff --git a/drivers/gpu/drm/gma500/psb_intel_modes.c b/drivers/gpu/drm/gma500/psb_intel_modes.c
> index 8be0ec340de5..45b10f30a2a9 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_modes.c
> +++ b/drivers/gpu/drm/gma500/psb_intel_modes.c
> @@ -11,37 +11,6 @@
>
>  #include "psb_intel_drv.h"
>
> -/**
> - * psb_intel_ddc_probe
> - * @adapter:   Associated I2C adaptor
> - */
> -bool psb_intel_ddc_probe(struct i2c_adapter *adapter)
> -{
> -       u8 out_buf[] = { 0x0, 0x0 };
> -       u8 buf[2];
> -       int ret;
> -       struct i2c_msg msgs[] = {
> -               {
> -                .addr = 0x50,
> -                .flags = 0,
> -                .len = 1,
> -                .buf = out_buf,
> -                },
> -               {
> -                .addr = 0x50,
> -                .flags = I2C_M_RD,
> -                .len = 1,
> -                .buf = buf,
> -                }
> -       };
> -
> -       ret = i2c_transfer(adapter, msgs, 2);
> -       if (ret == 2)
> -               return true;
> -
> -       return false;
> -}
> -
>  /**
>   * psb_intel_ddc_get_modes - get modelist from monitor
>   * @connector: DRM connector device to use
> --
> 2.48.1
>