Re: [PATCH] x86/sev: Make SEV_STATUS available via SYSFS
From: Joerg Roedel
Date: Mon Mar 10 2025 - 06:28:57 EST
On Thu, Mar 06, 2025 at 11:37:28AM +0100, Alexey Gladkov (Intel) wrote:
> I was thinking to suggest something like that
>
> /sys/firmware/coco/tdx/...
> /sys/firmware/coco/sev/...
So on a second thought I'd like to vote for the /sys/hypervisor/
hierarchy. The `firmware` term is a bit amibious here, the TDX module
can be seen as a kind of firmware for the guest OS, but realistically it
is more like another hypervisor sitting between KVM and the guest.
Also the settings on the SEV side that need to be exposed (VMPL and
SEV_STATUS) are CPU properties, but on the other side also set by some
form of hypervisor (either KVM/QEMU, the SVSM, or some other paravisor
in-between).
Overall /sys/hypervisor/ seems to be the best-fitting location for all
this data. To avoid ambiguation I propose:
/sys/hypervisor/common/[coco/]tdx/
/sys/hypervisor/common/[coco/]sev/
Using `common` makes it clear that this directory does not point to some
sort of Hypervisor, but to data common to all hypervisors. Using another
`coco` subdirectory is not necessary in my view, but if people think it
should exist I am fine with that.
Is this something we can agree on?
Regards,
Joerg