Re: [PATCH] drm/arm: Suppress "ARM devices" menu if not essential

[Liviu Dudau]

On Mon, Mar 10, 2025 at 03:23:57PM +0800, WangYuli wrote:
> Manifestly, the "ARM devices" menu is appropriate only for the ARM
> architecture.
> 
> Inasmuch as every single item in this menu is predicated on
> (ARM || ARM64 || COMPILE_TEST), it is therefore illogical for the
> "ARM devices" menu itself not to be predicated upon
> (ARM || ARM64 || COMPILE_TEST), and displaying a blank menu in other
> architectures is unwarranted.

Arm's Display IP is not tied to the Arm architecture. Anyone can license
and use the IP with any CPU architecture. The fact that so far the IP has
only been present in a handful of devices doesn't mean we should restrict
the drivers.

What is the issue that you're trying to solve here?

Best regards,
Liviu

> 
> Signed-off-by: WangYuli <wangyuli@xxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/arm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig
> index c901ac00c0c3..0aa6a54567b6 100644
> --- a/drivers/gpu/drm/arm/Kconfig
> +++ b/drivers/gpu/drm/arm/Kconfig
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  menu "ARM devices"
> -	depends on DRM
> +	depends on DRM && (ARM || ARM64 || COMPILE_TEST)
>  
>  config DRM_HDLCD
>  	tristate "ARM HDLCD"
> -- 
> 2.47.2
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯