Re: [PATCH 1/2] dt-bindings: PCI: fsl,layerscape-pcie-ep: Drop deprecated windows
From: Rob Herring
Date: Mon Mar 10 2025 - 08:53:15 EST
On Fri, Mar 07, 2025 at 09:13:26AM +0100, Krzysztof Kozlowski wrote:
> The example DTS uses 'num-ib-windows' and 'num-ob-windows' properties
> but these are not defined in the binding. Binding also does not
> reference snps,dw-pcie-common.yaml, probably because it is quite
> different even though the device is based on Synopsys controller.
>
> The properties are actually deprecated, so simply drop them from the
> example.
How are we not getting warnings for them? That would be the bigger
issue. "status" shouldn't matter.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> index 399efa7364c9..1fdc899e7292 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie-ep.yaml
> @@ -94,8 +94,6 @@ examples:
> reg-names = "regs", "addr_space";
> interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; /* PME interrupt */
> interrupt-names = "pme";
> - num-ib-windows = <6>;
> - num-ob-windows = <8>;
> status = "disabled";
> };
> };
> --
> 2.43.0
>