Re: [PATCH V9 2/2] checkpatch: check format of Vec<String> in modules
From: Guilherme Giacomo Simoes
Date: Mon Mar 10 2025 - 09:07:22 EST
Joe Perches <joe@xxxxxxxxxxx> wrote:
> What happens if the patch contains more than one module?
Sincerely I do not was test this. I don't was think about when the patch
contains more than one module, is a critical problem that went unnoticed by me.
Thanks for noticing this.
I will make some tests for this and make some changes if neccessary.
> spaces contains both spaces and tabs.
> Why not test the strings rather than the length?
> Otherwise tab-space is the same length as space-tab.
You is right, we can test the string rather than length.
> Why is herevet_space_add more useful than herevet?
The $herevet_space_add store the $herevet for the added line. Otherwise, if the
change is like:
authors: [
+ author_1
author_2
author_3
]
The $expected_spaces and $spaces will be filled in the "author_2" line. And the
content of $herevet will be " author_2" rather than "+ author_1".
How the rust-side patch already is merged in rust-next, I only will send a
patch for this checkpatch.
I will make this changes that you suggested for me, and send a new patch.
Thanks,
Guilherme