Re: [PATCH v7 2/4] x86/cpu: Add cpu_type to struct x86_cpu_id

[Pawan Gupta]

On Sun, Mar 09, 2025 at 06:32:39PM +0100, Borislav Petkov wrote:
> On Thu, Mar 06, 2025 at 06:18:20PM -0800, Pawan Gupta wrote:
> > diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
> > index d67614f7b7f1..18e996acb49a 100644
> > --- a/include/linux/mod_devicetable.h
> > +++ b/include/linux/mod_devicetable.h
> > @@ -692,6 +692,7 @@ struct x86_cpu_id {
> >  	__u16 feature;	/* bit index */
> >  	/* Solely for kernel-internal use: DO NOT EXPORT to userspace! */
> >  	__u16 flags;
> > +	__u8  cpu_type;
> 
> The struct is called "x86_cpu_id" and all its members describe a CPU. There's
> no need to have more "cpu_" redundancy in the member names - just call that
> "type".  It is clear that it is about a CPU's type.

Makes sense, I will change it to "type".