Re: [PATCH hyperv-next v5 08/11] Drivers: hv: vmbus: Get the IRQ number from DeviceTree

[Roman Kisel]

On 3/8/2025 1:11 PM, Arnd Bergmann wrote:
> On Fri, Mar 7, 2025, at 23:03, Roman Kisel wrote:
> > +static int __maybe_unused vmbus_set_irq(struct platform_device *pdev)
>
> Instead of the __maybe_unused annotation here
>
> > +#ifndef HYPERVISOR_CALLBACK_VECTOR
> > +	ret = vmbus_set_irq(pdev);
> > +	if (ret)
> > +		return ret;
> > +#endif
> > +
>
> you can use
>
>         if (!__is_defined(HYPERVISOR_CALLBACK_VECTOR))
>                    ret = vmbus_set_irq(pdev);
>
> and make it a little more readable.

Thanks you very much, will update! Very neat :)

>      Arnd

--
Thank you,
Roman