Re: [PATCH net-next v9] net: mdio: Add RTL9300 MDIO driver

[Russell King (Oracle)]

On Mon, Mar 10, 2025 at 07:06:13PM +0100, Christophe JAILLET wrote:
> > +		err = of_property_read_u32(phy_dn, "reg", &addr);
> > +		if (err)
> > +			return err;
> > +
> > +		bitmap_set(priv->valid_ports, pn, 1);
> 
> set_bit(pn, priv->valid_ports) ?

If you don't need it to be atomic, then please use __set_bit().

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!