Re: [PATCH 2/2] regulator: assert that dummy regulator has been probed before using it

From: Mark Brown
Date: Mon Mar 10 2025 - 15:39:26 EST


On Mon, Mar 10, 2025 at 07:22:24PM +0100, Christian Eggers wrote:
> Am Montag, 10. März 2025, 18:23:02 CET schrieb Mark Brown:

> > > + BUG_ON(!r);

> > This doesn't actually help anything

> My idea was to help identifying the problem (if it is reintroduced again
> later).

> > I'd expect this to trigger probe deferral.

> I can check for this tomorrow. But is it worth to use deferred probing
> for a shared "NOP" driver which doesn't access any hardware? Or would this
> only introduce overhead for nothing?

My concern is that if something goes wrong in production then we've just
escallated the problem, given that there's a clear error handling
mechanism we could use we should take advantage of that rather than
doing something destructive.

Attachment: signature.asc
Description: PGP signature