Re: [PATCH net-next] dt-bindings: net: Define interrupt constraints for DWMAC vendor bindings
From: Rob Herring (Arm)
Date: Mon Mar 10 2025 - 17:16:45 EST
On Sun, 09 Mar 2025 00:33:01 +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> The `snps,dwmac.yaml` binding currently sets `maxItems: 3` for the
> `interrupts` and `interrupt-names` properties, but vendor bindings
> selecting `snps,dwmac.yaml` do not impose these limits.
>
> Define constraints for `interrupts` and `interrupt-names` properties in
> various DWMAC vendor bindings to ensure proper validation and consistency.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> Hi All,
>
> Based on recent patch [0] which increases the interrupts to 11
> and adds `additionalItems: true` its good to have constraints
> to validate the schema. Ive made the changes based on the DT
> binding doc and the users. Ive ran dt binding checks to ensure
> the constraints are valid. Please let me know if you'd like me
> to split this patch or if any of the constraints are incorrect,
> as I don't have documentation for all of these platforms.
>
> https://lore.kernel.org/all/20250308200921.1089980-2-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/
>
> Cheers, Prabhakar
> ---
> .../devicetree/bindings/net/amlogic,meson-dwmac.yaml | 6 ++++++
> .../devicetree/bindings/net/intel,dwmac-plat.yaml | 6 ++++++
> .../devicetree/bindings/net/mediatek-dwmac.yaml | 6 ++++++
> .../devicetree/bindings/net/nxp,dwmac-imx.yaml | 8 ++++++++
> .../devicetree/bindings/net/rockchip-dwmac.yaml | 10 ++++++++++
> Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 10 ++++++++++
> .../bindings/net/toshiba,visconti-dwmac.yaml | 6 ++++++
> 7 files changed, 52 insertions(+)
>
Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>