Re: [PATCH] x86/hweight: Fix and improve __arch_hweight{32,64}() assembly
From: Borislav Petkov
Date: Mon Mar 10 2025 - 17:35:00 EST
On Mon, Mar 10, 2025 at 10:18:50PM +0100, Uros Bizjak wrote:
> a) Use ASM_CALL_CONSTRAINT to prevent inline asm that includes call
> instruction from being scheduled by the compiler before the frame
> pointer gets set
> up by the containing function. This unconstrained scheduling might
> cause objtool to print a "call without frame pointer save/setup"
> warning.
>
> would be ok?
Yes, and pls say something along the lines of: this is not a currently
triggered issue but it can potentially happen, so that it is perfectly clear
what this patch is addressing.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette