Re: [PATCH v2 06/11] perf python: Add optional cpus and threads arguments to parse_events

[Namhyung Kim]

On Fri, Feb 28, 2025 at 02:23:03PM -0800, Ian Rogers wrote:
> Used for the evlist initialization.
> 
> Reviewed-by: Howard Chu <howardchu95@xxxxxxxxx>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
>  tools/perf/util/python.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c
> index b600b6379b4e..4a3015e7dc83 100644
> --- a/tools/perf/util/python.c
> +++ b/tools/perf/util/python.c
> @@ -1339,12 +1339,18 @@ static PyObject *pyrf__parse_events(PyObject *self, PyObject *args)
>  	struct evlist evlist = {};
>  	struct parse_events_error err;
>  	PyObject *result;
> +	PyObject *pcpus = NULL, *pthreads = NULL;
> +	struct perf_cpu_map *cpus;
> +	struct perf_thread_map *threads;
>  
> -	if (!PyArg_ParseTuple(args, "s", &input))
> +	if (!PyArg_ParseTuple(args, "s|OO", &input, &pcpus, &pthreads))
>  		return NULL;
>  
> +	threads = pthreads ? ((struct pyrf_thread_map *)pthreads)->threads : NULL;
> +	cpus = pcpus ? ((struct pyrf_cpu_map *)pcpus)->cpus : NULL;

I wonder if it needs any type checks before accessing them.

Thanks,
Namhyung

> +
>  	parse_events_error__init(&err);
> -	evlist__init(&evlist, NULL, NULL);
> +	evlist__init(&evlist, cpus, threads);
>  	if (parse_events(&evlist, input, &err)) {
>  		parse_events_error__print(&err, input);
>  		PyErr_SetFromErrno(PyExc_OSError);
> -- 
> 2.48.1.711.g2feabab25a-goog
>