Re: [PATCH] nvme-pci: Remove NVME_QUIRK_BOGUS_NID for device vendors

From: Christoph Hellwig
Date: Tue Mar 11 2025 - 03:54:31 EST


On Mon, Mar 10, 2025 at 10:58:45AM -0600, Keith Busch wrote:
> Setting the quirk on demand lets the first scanned namespace export the
> "unique" identifiers as their own. Scanning isn't deterministic if you
> have more than one, so you wouldn't readily know which actual namespace
> a particular /dev/disk/by-id/ link points to.

Agreed. The fact that we even allow the devices through is just to bow
down to the greast Linux dictator. It's still a very bad idea for all
the same reasons as it was before.