Re: [PATCH net-next v2 0/8] enic:enable 32, 64 byte cqes and get max rx/tx ring size from hw

From: Paolo Abeni
Date: Tue Mar 11 2025 - 05:25:27 EST


On 3/6/25 3:56 PM, Simon Horman wrote:
> On Tue, Mar 04, 2025 at 07:56:36PM -0500, Satish Kharat via B4 Relay wrote:
>> This series enables using the max rx and tx ring sizes read from hw.
>> For newer hw that can be up to 16k entries. This requires bigger
>> completion entries for rx queues. This series enables the use of the
>> 32 and 64 byte completion queues entries for enic rx queues on
>> supported hw versions. This is in addition to the exiting (default)
>> 16 byte rx cqes.
>>
>> Signed-off-by: Satish Kharat <satishkh@xxxxxxxxx>
>> ---
>> Changes in v2:
>> - Added net-next to the subject line.
>> - Removed inlines from function defs in .c file.
>> - Fixed function local variable style issues.
>> - Added couple of helper functions to common code.
>> - Fixed checkpatch errors and warnings.
>> - Link to v1: https://lore.kernel.org/r/20250227-enic_cleanup_and_ext_cq-v1-0-c314f95812bb@xxxxxxxxx
>>
>> ---
>> Satish Kharat (8):
>> enic: Move function from header file to c file
>> enic: enic rq code reorg
>> enic: enic rq extended cq defines
>> enic: enable rq extended cq support
>> enic : remove unused function cq_enet_wq_desc_dec
>> enic : added enic_wq.c and enic_wq.h
>> enic : cleanup of enic wq request completion path
>> enic : get max rq & wq entries supported by hw, 16K queues
>
> nit: please consistently use "enic: " as the subject prefix for
> the cover-letter and all patches in this patch-set.

Since it looks otherwise good to me, I'll adjust the above while
applying the patches.

Thanks,

Paolo