Re: [PATCH v2] bpf: bpftool: Setting error code in do_loader()

[Quentin Monnet]

2025-03-11 12:12 UTC+0900 ~ Sewon Nam <swnam0729@xxxxxxxxx>
> missing error code in do_loader()
> bpf_object__open_file() failed, but return 0
> This means the command's exit status code was successful, so make sure to return the correct error code.
> To maintain consistency with other locations where bpf_object__open_file() is called, it returns -1 instead.


Nit: Please wrap long lines in the commit description next time you send
a patch.


> 
> Link: https://lore.kernel.org/bpf/d3b5b4b4-19bb-4619-b4dd-86c958c4a367@stanley.mountain/t/#u


Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>


> Closes: https://github.com/libbpf/bpftool/issues/156
> Signed-off-by: Sewon Nam <swnam0729@xxxxxxxxx>

Tested-by: Quentin Monnet <qmo@xxxxxxxxxx>
Reviewed-by: Quentin Monnet <qmo@xxxxxxxxxx>

Thank you!