Re: [PATCH] fork: Remove unnecessary size argument when calling strscpy()

[Lorenzo Stoakes]

On Tue, Mar 11, 2025 at 12:05:39PM +0100, Thorsten Blum wrote:
> The size parameter is optional and strscpy() automatically determines
> the length of the destination buffer using sizeof() if the argument is
> omitted. This makes the explicit sizeof() unnecessary. Remove it to
> simplify the code.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Hm not sure about this one, it's not really simplifying anything all too
much and seems like somewhat useless churn?

It's pretty clear what's going on here already.

> ---
>  kernel/fork.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 735405a9c5f3..81eef131e23c 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -2248,7 +2248,7 @@ __latent_entropy struct task_struct *copy_process(
>  		p->flags |= PF_IO_WORKER;
>
>  	if (args->name)
> -		strscpy_pad(p->comm, args->name, sizeof(p->comm));
> +		strscpy_pad(p->comm, args->name);
>
>  	p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? args->child_tid : NULL;
>  	/*
> --
> 2.48.1
>