RE: [RFC PATCH 1/3] thermal/cpuplog_cooling: Add CPU hotplug cooling driver

[John Madieu]

Hi Geert,

Thanks for your review.

> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Tuesday, March 11, 2025 9:28 AM
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [RFC PATCH 1/3] thermal/cpuplog_cooling: Add CPU hotplug
> cooling driver
> 
> Hi John,
> 
> On Sun, 9 Mar 2025 at 13:14, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> wrote:
> > Add thermal cooling mechanism that dynamically manages CPU
> > online/offline states to prevent overheating. It registers  per-CPU
> > cooling devices that can take CPUs offline when thermal thresholds are
> > excee and that integrates with the Linux thermal framework as a cooling
> devices.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/drivers/thermal/cpuplug_cooling.c
> 
> > +static int register_cpu_hotplug_cooling(struct device_node *cpu_node,
> > +                                       int cpu_id) {
> 
> > +       hotplug_cdev = kzalloc(sizeof(*hotplug_cdev), GFP_KERNEL);
> > +       if (!hotplug_cdev) {
> > +               pr_err("Failed to allocate memory for cooling
> > + device\n");
> 
> scripts/checkpatch.pl:
> 
> WARNING: Possible unnecessary 'out of memory' message
> 
> and checkpatch is right, as the memory core already takes care of printing
> a message.
> 

Will be removed in v2.

> > +               return -ENOMEM;
> > +       }
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --

Regards,
John