Re: [PATCH 0/5] printk: renaming some suspend/resume functions and one fix for unblanking
From: Petr Mladek
Date: Tue Mar 11 2025 - 08:43:50 EST
On Tue 2025-03-11 11:38:00, Petr Mladek wrote:
> On Wed 2025-02-26 16:59:00, Marcos Paulo de Souza wrote:
> > Hello, I've being working on some patches that help to clarify the suspend/resume
> > of printk machinery. The last patch on this patchset address one issue regarding
> > suspended consoles and blanking.
> >
> > This is a part one patchset that I would like to see merged before I send more patches
> > that will rework the suspend flag (a global suspend flag istead of per console) and
> > the removal of CON_ENABLED flag later on (I've created a function that will forcibly)
> > register the console instead of using this flag.
> >
> > Please review!
> >
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>
>
> Looks good to me. I could fix the typos when pushing.
>
> Well, there is one more thing. It seems that the simple graphic logger
> was merged for 6.14-rc1. And the console_stop()/console_start() API
> is used also in drivers/gpu/drm/clients/drm_log.c.
>
> It is actually the code which motivated this rename, as already
> pointed out by John, see
> https://lore.kernel.org/lkml/ZyoNZfLT6tlVAWjO@xxxxxxxxxxxxxxx/
>
> Well, I am going to update these two locations when pushing this
> as well. Let's just get this change done.
And I did as mentioned above.
JFYI, the patcheset has been committed into printk/linux.git,
branch for-6.15-console-suspend-api-cleanup.
Best Regards,
Petr