Re: [PATCH] xfs: remove unnecessary NULL check before kvfree()

[Darrick J. Wong]

On Tue, Mar 11, 2025 at 03:11:14PM +0800, Chen Ni wrote:
> Remove unnecessary NULL check before kvfree() reported by
> Coccinelle/coccicheck and the semantic patch at
> scripts/coccinelle/free/ifnullfree.cocci.
> 
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>

Probably fine, though the line numbers have moved around a lot in
for-next...

Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>

--D

> ---
>  fs/xfs/xfs_rtalloc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index 57bef567e011..9688e8ca6915 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -1144,8 +1144,7 @@ xfs_growfs_rtg(
>  			goto out_error;
>  	}
>  
> -	if (old_rsum_cache)
> -		kvfree(old_rsum_cache);
> +	kvfree(old_rsum_cache);
>  	xfs_rtgroup_rele(rtg);
>  	return 0;
>  
> -- 
> 2.25.1
> 
>