Re: [PATCH v2] perf mem: Don't leak mem event names
From: Namhyung Kim
Date: Tue Mar 11 2025 - 12:12:06 EST
On Fri, 07 Mar 2025 17:28:53 -0800, Ian Rogers wrote:
> When preparing the mem events for the argv copies are intentionally
> made. These copies are leaked and cause runs of perf using address
> sanitizer to fail. Rather than leak the memory allocate a chunk of
> memory for the mem event names upfront and build the strings in this -
> the storage is sized larger than the previous buffer size. The caller
> is then responsible for clearing up this memory. As part of this
> change, remove the mem_loads_name and mem_stores_name global buffers
> then change the perf_pmu__mem_events_name to write to an out argument
> buffer.
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung