Re: [PATCH net-next] qed: remove cast to pointers passed to kfree

[Michal Kubiak]

On Tue, Mar 11, 2025 at 03:06:24PM +0800, Chen Ni wrote:
> Remove unnecessary casts to pointer types passed to kfree.
> Issue detected by coccinelle:
> @@
> type t1;
> expression *e;
> @@
> 
> -kfree((t1 *)e);
> +kfree(e);
> 
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index f915c423fe70..886061d7351a 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -454,7 +454,7 @@ int qed_fill_dev_info(struct qed_dev *cdev,
>  
>  static void qed_free_cdev(struct qed_dev *cdev)
>  {
> -	kfree((void *)cdev);
> +	kfree(cdev);
>  }
>  
>  static struct qed_dev *qed_alloc_cdev(struct pci_dev *pdev)
> -- 
> 2.25.1
> 
> 


LGTM.

Thanks,
Reviewed-by: Michal Kubiak <michal.kubiak@xxxxxxxxx>