Re: [PATCH v7 00/49] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

[James Morse]

Hi Amit,

On 07/03/2025 13:50, Amit Singh Tomar wrote:
> On 3/7/2025 3:57 PM, Amit Singh Tomar wrote:
>> Changes since v6?:
>>
>>>   * All the excitement is in patch 37, turns out there are two rmdir() paths
>>>     that don't join up.
>>> The last eight patches are new:
>>>   * The python script has been replaced with the patch that it generates, see
>>>     the bare branch below if you want to regenerate it.
>>>   * There have been comments on the followup to the generated patch, those are
>>>     included here - I suggest they be squashed into the generated patch.
>>>   * This version includes some checkpatch linting from Dave.
>>>
>>> ---
>>> This series renames functions and moves code around. With the
>>> exception of invalid configurations for the configurable-events, there should
>>> be no changes in behaviour caused by this series. It is now possible for
>>> throttle_mode to report 'undefined', but no known platform will do this.
>>>
>>> The driving pattern is to make things like struct rdtgroup private to resctrl.
>>> Features like pseudo-lock aren't going to work on arm64, the ability to disable
>>> it at compile time is added.
>>>
>>> After this, I can start posting the MPAM driver to make use of resctrl on arm64.
>>> (What's MPAM? See the cover letter of the first series. [1])
>>>
>>> This series is based on v6.14-rc3 and can be retrieved from:
>>> https://urldefense.proofpoint.com/v2/url?
>>> u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_morse_linux.git&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=V_GK7jRuCHDErm6txmgDK1-MbUihtnSQ3gPgB-A-JKU&m=nuwqirfPj-0yJqyDZfy25skE_NJ-fYFcygpI04RUICnSUBYHutdqE6Gakd1Z3I8H&s=34Q-cAJD41LWUgU21FvoSkXHOM-uSrOs2a1vEwaxrNE&e= <https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_morse_linux.git&d=DwIDAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=V_GK7jRuCHDErm6txmgDK1-MbUihtnSQ3gPgB-A-JKU&m=nuwqirfPj-0yJqyDZfy25skE_NJ-fYFcygpI04RUICnSUBYHutdqE6Gakd1Z3I8H&s=34Q-cAJD41LWUgU21FvoSkXHOM-uSrOs2a1vEwaxrNE&e=> mpam/move_to_fs/v7
>>> or for those who want to regnerate the patch that moves all the code:
>>
>> After rebasing mpam/snapshot/v6.14-rc1 on top of this series,

Hmmm - right, because this series doesn't contain the python script that generates
patch-45, so git can't know that all the code is the same.


>> Tested a few MPAM
>> controls, including Cache Portion Partitioning and Memory Bandwidth Partitioning, on
>> Marvell CN10K ARM64 platform, and It looks good.

Thanks!


>> For this patch-set:
>> Tested-by: amitsinght@xxxxxxxxxxx
> Realized I used an incorrect format for the Tested-by tag, correcting it now
> 
> Tested-by: Amit Singh Tomar <amitsinght@xxxxxxxxxxx>

I'll add an '# arm64' suffix on that as that's what got tested.


Thanks,

Jaems