Re: [PATCH] x86/stackprotector: fix build failure with CONFIG_STACKPROTECTOR=n
From: Oleg Nesterov
Date: Tue Mar 11 2025 - 17:42:57 EST
On 03/11, Brian Gerst wrote:
>
> On Tue, Mar 11, 2025 at 3:24 PM Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> >
> > OK. I'll update the subject/changelog to explain that this is only
> > needed for the older binutils and send V2.
>
> With it conditional on CONFIG_STACKPROTECTOR, you can also drop PROVIDES().
Sorry Brian, I don't understand this magic even remotely...
Do you mean
-/* needed for Clang - see arch/x86/entry/entry.S */
-PROVIDE(__ref_stack_chk_guard = __stack_chk_guard);
+#ifdef CONFIG_STACKPROTECTOR
+__ref_stack_chk_guard = __stack_chk_guard;
+#endif
?
Oleg.