Re: [PATCH] i2c: cadence: fix call balance of id->clk handling routines

From: Andi Shyti
Date: Tue Mar 11 2025 - 18:53:06 EST


Hi Vitalii,

On Mon, Mar 03, 2025 at 05:08:05PM +0300, Vitalii Mordan wrote:
> If the clock id->clk was not enabled in cdns_i2c_probe(), it should not be
> disabled in any execution path. If the clock was not enabled, the probe
> function should return an error code.
>
> Use the devm_clk_get_enabled() helper function to ensure proper call
> balance for id->clk.
>
> Found by Linux Verification Center (linuxtesting.org) with Klever.
>
> Fixes: df8eb5691c48 ("i2c: Add driver for Cadence I2C controller")
> Signed-off-by: Vitalii Mordan <mordan@xxxxxxxxx>

Thanks for this patch, but it was already sent previously by
Michal and Manikanta.

Thanks,
Andi