Re: [PATCH 0/2] selftests: livepatch: test if ftrace can trace a livepatched function

[Marcos Paulo de Souza]

On Thu, 2025-03-06 at 18:51 -0300, Filipe Xavier wrote:
> This patchset add ftrace helpers functions and
> add a new test makes sure that ftrace can trace
> a function that was introduced by a livepatch.
> 
> Signed-off-by: Filipe Xavier <felipeaggger@xxxxxxxxx>
> ---
> Filipe Xavier (2):
>       selftests: livepatch: add new ftrace helpers functions
>       selftests: livepatch: test if ftrace can trace a livepatched
> function
> 
>  tools/testing/selftests/livepatch/functions.sh   | 45
> ++++++++++++++++++++++++
>  tools/testing/selftests/livepatch/test-ftrace.sh | 35
> ++++++++++++++++++
>  2 files changed, 80 insertions(+)
> 

Thanks for sending this new version! One interesting thing is that you
created a new patchset, instead of iterating on the same one, and this
triggered a bug on b4[1]!

You also missed the changelog since v2, but AFAICS you addressed all
comments from me, Joe and Petr, per [2].

For the two patches:

Reviewed-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx>

[1]: https://github.com/mricon/b4/issues/58
[2]:
https://lore.kernel.org/live-patching/b2637bad-9022-496a-9b83-0d348a6350b4@xxxxxxxxx/T/#m14bc5c118490c1b17e782a0f0173c1fb70d187c7

> ---
> base-commit: 848e076317446f9c663771ddec142d7c2eb4cb43
> change-id: 20250306-ftrace-sftest-livepatch-60d9dc472235
> 
> Best regards,