Re: [PATCH 2/4] nvme-multipath: add the NVME_MULTIPATH_PARAM config option
From: John Meneghini
Date: Tue Mar 11 2025 - 22:35:59 EST
On 3/5/25 9:33 AM, Christoph Hellwig wrote:
On Thu, Feb 27, 2025 at 10:25:39PM -0500, John Meneghini wrote:
The NVME_MULTIPATH_PARAM option controls the core.nvme_multipath module
parameter. When NVME_MULTIPATH_PARAM=n the multipath parameter is removed
and core nvme multipathing is enabled. When NVME_MULTIPATH_PARAM=y
the multipath parameter is added and multipath support becomes
configurable with the core.nvme_multipath parameter.
What's the point of adding yet another confusing option?
If you'll read the kConfig description, hopefully it's not confusing.
The whole point of this patch series is to remove the core.nvme_mulipath parameter.
This is what the patch at: https://lore.kernel.org/linux-nvme/20250204211158.43126-1-bgurney@xxxxxxxxxx/
does, and this is what this patch does. Since people didn't want to remove core.nvme_multipath parameter
in https://lore.kernel.org/linux-nvme/20250204211158.43126-1-bgurney@xxxxxxxxxx/ I've proposed this
patch as an alternative.
It provides a kConfig option to remove the core.nvme_multipath parameter so those who want it
can keep it, and those who don't and compile it out.
/John