Re: [PATCH v8:for-boris 00/30] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

From: Reinette Chatre
Date: Wed Mar 12 2025 - 01:05:02 EST


Hi James and Boris,

On 3/11/25 11:36 AM, James Morse wrote:
> Changes since v7?:
> * Series split to the first 30 patches, requested by Boris.
> * Fixed stale function names, definitions/declartions and typos.
> * Dropped the use of the default ctrlval helper in cache_alloc_hsw_probe()
>
> As ever, changes are noted on each patch.
> ---
> This series renames functions and moves code around. With the
> exception of invalid configurations for the configurable-events, there should
> be no changes in behaviour caused by this series. It is now possible for
> throttle_mode to report 'undefined', but no known platform will do this.
>
> The driving pattern is to make things like struct rdtgroup private to resctrl.
> Features like pseudo-lock aren't going to work on arm64, the ability to disable
> it at compile time is added.
>
> All this is to allow the filesystem portions of resctrl to be moved to live in /fs/,
> which allows resctrl to be supported by other architecture, such as arm64's MPAM.
> (What's MPAM? See the cover letter of the first series. [1])
>
> This series is based on v6.14-rc3 and can be retrieved from:
> https://git.kernel.org/pub/scm/linux/kernel/git/morse/linux.git mpam/move_to_fs/v8_for_boris
>
> As ever - bugs welcome,
> Thanks,
>
> James

This series looks good to me (just one nit in patch #22). All patches should have
my "Reviewed-by" tag now.

This series passed my testing with only a 0-day report outstanding. Since v7 passed a
0-day check I do not expect there to be issues with this. I believe 0-day will also
automatically run a check when patches land in tip.

Thank you very much.

Reinette