Re: [PATCH v5 01/10] xfs: Pass flags to xfs_reflink_allocate_cow()

[John Garry]

On 12/03/2025 07:15, Christoph Hellwig wrote:
> All the patches (but not the cover letter) capitalize the first
> word after the prefix.  While some subsystems do that, xfs does not.
> Please be consistent with the other commit messages.
>
> > +/*
> > + * Flags for xfs_reflink_allocate_cow()
> > + */
> > +#define XFS_REFLINK_CONVERT	(1u << 0) /* convert unwritten extents now */
>
> Please add a _UNWRITTEN prefix to avoid any confusion with delalloc
> conversions.

ok, fine

Thanks,
John