Re: [PATCH] watchdog: Add driver for Intel OC WDT

[Krzysztof Kozlowski]

On 11/03/2025 14:18, Diogo Ivo wrote:
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index f81705f8539aa0b12d156a86aae521aa40b4527d..16e6df441bb344c0f91b40bd76b6322ad3016e72 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1350,6 +1350,17 @@ config INTEL_MID_WATCHDOG
>  
>  	  To compile this driver as a module, choose M here.
>  
> +config INTEL_OC_WATCHDOG
> +	tristate "Intel OC Watchdog"
> +	depends on X86 && ACPI

Why can't this be compile tested?

...

> +static const struct acpi_device_id intel_oc_wdt_match[] = {
> +	{ "INT3F0D" },
> +	{ "INTC1099" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(acpi, intel_oc_wdt_match);
> +
> +static struct platform_driver intel_oc_wdt_platform_driver = {
> +	.driver = {
> +		.name = DRV_NAME,
> +		.acpi_match_table = ACPI_PTR(intel_oc_wdt_match),

Drop ACPI_PTR, causes warnigns and is not really beneficial.

> +	},
> +	.probe = intel_oc_wdt_probe,
> +};
> +
> +module_platform_driver(intel_oc_wdt_platform_driver);
> +
> +MODULE_AUTHOR("Diogo Ivo <diogo.ivo@xxxxxxxxxxx>");
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("Intel OC Watchdog driver");
> +MODULE_ALIAS("platform:" DRV_NAME);

Drop alias, you have match table.


Best regards,
Krzysztof