RE: [PATCH 2/2] arm64: dts: exynos: Add DT node for all UART ports

From: Faraz Ata
Date: Wed Mar 12 2025 - 05:11:09 EST


Hello Krzysztof

> -----Original Message-----
> On 12/03/2025 07:19, Faraz Ata wrote:
> > Universal Serial Interface (USI) supports three serial protocol like
> > uart, i2c and spi. ExynosAutov920 has 18 instances of USI.
> > Add all the USI DT node and subsequent uart nodes for all the instances.
> >
> > Signed-off-by: Faraz Ata <faraz.ata@xxxxxxxxxxx>
> > ---
> > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 494
> > ++++++++++++++++++
> > 1 file changed, 494 insertions(+)
>
>
> Please do not combine DTS changes with serial patches, ever. DTS has to go
> via separate tree.
>
Sure, while sending v2, I will send DT separately and serial driver change separately.
Thanks for your review.
> ...
>
.
.
.
> > +
> > +
>
> Just one blank line.
Sure will correct in v2.

>
> > pwm: pwm@109b0000 {
> > compatible = "samsung,exynosautov920-pwm",
> > "samsung,exynos4210-pwm";
>
>
> Best regards,
> Krzysztof